fix: repair syntax errors that break the build on main - #1683
Conversation
package.json: the overrides block was missing a comma after nanoid and had a duplicate postcss key, making it invalid JSON (npm ci fails to parse it). Deduped postcss to the newer pin and fixed the comma. cryptoWorkerClient.ts: two statements were on one line with no separator after the Worker constructor, a TypeScript parse error. Split onto separate lines.
|
@vedant7007 is attempting to deploy a commit to the csxark's projects Team on Vercel. A member of the Team first needs to authorize it. |
🎉 Thank You for Your ContributionHello @vedant7007, Thank you for submitting a Pull Request to CryptoViz. We appreciate the time and effort you've invested in contributing to the project. Your Pull Request has been received successfully and will be reviewed by the maintainers as soon as possible. 📋 Pull Request Checklist
Ensuring these requirements are met helps streamline the review process and enables maintainers to review your contribution more efficiently. ❤️ Support CryptoVizIf you find CryptoViz helpful, consider supporting the project by:
Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community! Thank you once again for contributing to CryptoViz. We appreciate your support and look forward to reviewing your contribution. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change fixes invalid JSON in ChangesBuild Parse Fixes
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The changes restore package and TypeScript parsing without altering runtime behavior or public interfaces. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
csxark
added
ECSoC26
🎉 Pull Request MergedHello @vedant7007, Thank you for your contribution to CryptoViz. Your Pull Request has been reviewed and successfully merged into the project. We sincerely appreciate the time and effort you invested in improving the project. Contributions like yours help make CryptoViz better for the entire community. We look forward to your future contributions and hope to collaborate with you again. ❤️ Support CryptoVizIf you find CryptoViz helpful, consider supporting the project by:
Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community! |
## Description Implemented proper dialog semantics and focus management for the Team Invite Modal to meet accessibility standards, resolving Issue csxark#1683. --- ## Related Issue Closes csxark#1683 --- ## Changes Made - Created an `AccessibleDialog` wrapper component (implementing ARIA specifications). - Added `role="dialog"` and `aria-modal="true"`. - Linked the dialog title to `aria-labelledby` for screen readers. - Added a `useEffect` hook to explicitly trap focus inside the modal using `Tab` and `Shift+Tab`. - Added an event listener to close the modal when the `Escape` key is pressed. - Captured `document.activeElement` on mount to successfully restore focus to the triggering button when the modal closes. - Updated `InviteMemberForm.jsx` to utilize this new accessible wrapper. - Wrote RTL/Jest tests verifying semantics, focus trapping, escape handling, and focus restoration. --- ## Testing - [x] Dialog semantics test. - [x] Focus-trap interaction test. - [x] Escape-key test. - [x] Focus restoration test. - [x] Tested manually with keyboard navigation to ensure focus doesn't leak into the background DOM.
2 participants
What & why
Closes #1682.
maindoesn't parse right now — two committed syntax errors break the build before typecheck/tests run.Changes
package.json— theoverridesblock was invalid JSON: missing a comma afternanoidand a duplicatepostcsskey. Dedupedpostcssto the newer pin (^8.5.26) and restored the comma.npm cinow parses it.lib/workers/cryptoWorkerClient.ts:71— two statements were jammed onto one line after theWorkerconstructor (a TS parse error). Split theonmessageassignment onto its own line.Both are mechanical, no behavior change.
Verification
node -e "JSON.parse(require('fs').readFileSync('package.json'))"— parses.tsc --noEmitno longer reports thecryptoWorkerClient.ts:71parse error (remaining tsc output is unrelated pre-existing items inlib/cipher/*, untouched here).Contributing as part of Elite Coders Summer of Code (ECSoC 2026).
Summary by CodeRabbit